USHIFT-7381: fix(microshift-ci): fix PCP dashboard rendering inside Spyglass#240
Merged
openshift-merge-bot[bot] merged 5 commits intoJul 24, 2026
Conversation
Replace height: 100vh and overflow: hidden with percentage-based height and min-height. Spyglass embeds custom-link HTML in a container where 100vh resolves incorrectly, causing the dashboard to render as a blank black page. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: suleymanakbas91 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Contributor
WalkthroughThe PCP dashboard layout now uses full-height sizing with a 600px minimum and a fixed 400px empty-state height. Hypervisor build ID extraction uses an artifacts-relative path. The microshift-ci plugin version is updated to 1.5.1. ChangesMicroshift CI updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 10 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (10 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
openshift-ci
Bot
added
the
ready-for-human-review
suleymanakbas91
changed the title
…mode The numeric-only regex in process_hypervisor_dir() failed to match the "local" build_id used in --local mode, causing hypervisor PCP data to be silently skipped. Replace with simple path component extraction that handles both numeric and "local" build IDs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/microshift-ci/scripts/pcp-graphs/generate-dashboard.sh`:
- Around line 264-265: Add tests for the build_id extraction in the
generate-dashboard flow, covering positive numeric IDs, the literal “local”
identifier, and malformed artifact-relative paths. Verify each case produces the
expected grouping key, including rejection or handling of invalid paths
according to the existing script behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 726231b7-0755-4e68-804a-52213b7530cc
📒 Files selected for processing (1)
plugins/microshift-ci/scripts/pcp-graphs/generate-dashboard.sh
Cover build_id extraction for both URL mode (numeric) and local mode
("local"), tarball path parsing (scenario, VM host), and malformed
input. Addresses CONTRIBUTING.md requirement for validation/parsing
test coverage.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This reverts commit 5118855.
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
height: 100vh; overflow: hiddenwithhtml,body { height: 100% }andmin-height: 600pxon bodyheight: 60vhon empty-state with fixed400px100vhresolves to 0, causing the dashboard to render as a blank pageTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit